lkml.org 
[lkml]   [2010]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 5/9] mfd: Add UART support for the ST-Ericsson CG2900.
    From
    2010/10/28 Arnd Bergmann <arnd@arndb.de>:
    > On Friday 22 October 2010, Par-Gunnar Hjalmdahl wrote:
    >
    >> >
    >> > So - NAK this for the moment, it needs to be split cleanly into ldisc
    >> > (thing which speaks the protocol and eg sees "speed change required" and
    >> > acts on it) and device (thing which knows about the hardware).
    >>
    >> OK. We will try to figure out a new design.
    >> I'm not too happy about putting the ldisc part in Bluetooth though
    >> since it is only partly Bluetooth, it is also GPS and FM. Better could
    >> maybe be under char/?
    >
    > After getting a better idea of what the base mfd driver does, my impression
    > is now that you should not register a second N_HCI line discipline at all,
    > but instead extend the existing line discipline with this number.
    >
    > I'm not sure what happens if you need two modules that try to register
    > the same ldisc number, but I imagine it is not good.
    >
    > Shouldn't you instead be using the drivers/bluetooth/hci_{ldisc,h4} code?
    >
    >        Arnd
    >

    We also need the ldisc code to handle events from FM and GPS and since
    that is chip specific we cannot add that to the generic hci_ldisc
    code.
    I agree that we might run into problems if two drivers try to register
    the same line discipline. It might then be better to introduce a new
    line discipline then even though that could cause other problems. I do
    not know if it is possible to add a condition in Kconfig otherwise so
    the CG2900 ldisc cannot be active while the "normal" ldisc driver is
    selected.

    /P-G
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-10-29 14:01    [W:0.026 / U:29.152 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site