Messages in this thread | | | Date | Wed, 27 Oct 2010 21:28:34 -0700 | From | Guenter Roeck <> | Subject | Re: [RFC PATCH] include/linux/kernel.h: Add config option for pr_fmt(fmt) |
| |
On Wed, Oct 27, 2010 at 01:41:41PM -0400, Joe Perches wrote: > On Tue, 2010-10-26 at 11:03 +0200, Jean Delvare wrote: > > On Thu, 21 Oct 2010 19:19:42 -0700, Joe Perches wrote: > > > Change the default #define pr_fmt(fmt) from: > > > - #define pr_fmt(fmt) fmt > > > to: > > > - #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > > This will standard use of prefixes and prevent the > > > addition of new #defines when using pr_<level>. > > I'm all for it! > > > Adds a config option to use the old style if desired. > > Not sure what the idea is. Once pr_fmt() includes the module name, we > > will drop hard-coded prefixes in all log messages throughout the kernel > > tree. Once this is done, a kernel built with PR_FMT_IS_KBUILD_MODNAME=n > > would become horribly confusing. > > True. The idea is to allow a transition period and remove > this PR_FMT_IS_KBUILD_MODNAME config option later. > Personally I would prefer to just make the change without config option.
However, if that is not acceptable, a config option which is enabled by default would still be better than nothing - and much better than hundreds of pr_fmt() spread throughout the code. Feel free to add my Acked-by, whatever that may help.
Guenter
| |