lkml.org 
[lkml]   [2010]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 0/4] IMA: making i_readcount a first class inode citizen
From
Date
On Thu, 2010-10-28 at 18:45 -0400, Eric Paris wrote:
> On Thu, 2010-10-28 at 15:29 -0700, Linus Torvalds wrote:
> > On Thu, Oct 28, 2010 at 3:24 PM, Dave Chinner <david@fromorbit.com> wrote:
> > >
> > > Why the wrapper functions and locking? Why not an atomic variable like
> > > i_writecount?
> >
> > Indeed. With moving this more into the VFS, let's just make sure it
> > looks like i_writecount as much as possible.
>
> My thought was that the IMA read/write checks should happen AFTER the
> i_writecount and i_readcount counters were updated. Thus even if we
> raced with another task we can rest assured that the other task would
> catch the situation we missed....
>
> -Eric

Thanks Eric. My misunderstanding. Will update the patches, making
i_readcount atomic.

Mimi



\
 
 \ /
  Last update: 2010-10-29 02:33    [W:0.068 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site