Messages in this thread | | | Date | Thu, 28 Oct 2010 15:35:13 +0800 | From | Xiao Guangrong <> | Subject | Re: [PATCH 5/8] KVM: don't touch vcpu stat after async pf is complete |
| |
On 10/27/2010 06:44 PM, Gleb Natapov wrote: > On Wed, Oct 27, 2010 at 05:05:57PM +0800, Xiao Guangrong wrote: >> Don't make a KVM_REQ_UNHALT request after async pf is completed since it >> can break guest's 'halt' instruction. >> > Why is it a problem? CPU may be unhalted by different events so OS > shouldn't depend on it. >
We don't know how guest OS handles it after HLT instruction is completed, according to X86's spec, only NMI/INTR/RESET/INIT/SMI can break halt state, it violations the hardware behavior if we allow other event break this state. Your opinion? :-)
| |