lkml.org 
[lkml]   [2010]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCHv2 5/7] USB: gadget: f_mass_storage: remove needless complete()
    Date
    This commit removes call to the complete() function done in
    fsg_unbind() which was never needed there but was a leftover
    form file_storage.c.

    Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
    ---
    drivers/usb/gadget/f_mass_storage.c | 5 +----
    1 files changed, 1 insertions(+), 4 deletions(-)

    diff --git a/drivers/usb/gadget/f_mass_storage.c b/drivers/usb/gadget/f_mass_storage.c
    index c71f69f..365f1b3 100644
    --- a/drivers/usb/gadget/f_mass_storage.c
    +++ b/drivers/usb/gadget/f_mass_storage.c
    @@ -2657,7 +2657,7 @@ static int fsg_main_thread(void *common_)
    up_write(&common->filesem);
    }

    - /* Let the unbind and cleanup routines know the thread has exited */
    + /* Let fsg_unbind() know the thread has exited */
    complete_and_exit(&common->thread_notifier, 0);
    }

    @@ -2906,9 +2906,6 @@ static void fsg_common_release(struct kref *ref)
    if (common->state != FSG_STATE_TERMINATED) {
    raise_exception(common, FSG_STATE_EXIT);
    wait_for_completion(&common->thread_notifier);
    -
    - /* The cleanup routine waits for this completion also */
    - complete(&common->thread_notifier);
    }

    if (likely(common->luns)) {
    --
    1.7.1


    \
     
     \ /
      Last update: 2010-10-28 17:35    [W:0.020 / U:59.596 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site