lkml.org 
[lkml]   [2010]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/4] fs: factor inode disposal
    >  /*
    > + * Free the inode passed in, removing it from the lists it is still connected
    > + * to but avoiding unnecessary lock round-trips for the lists it is no longer
    > + * on.
    > + *
    > + * An inode must already be marked I_FREEING so that we avoid the inode being
    > + * moved back onto lists if we race with other code that manipulates the lists
    > + * (e.g. writeback_single_inode_inode). The caller is responsisble for setting this.

    Too long line.

    > + */
    > +static void dispose_one_inode(struct inode *inode)
    > +{
    > + BUG_ON(!(inode->i_state & I_FREEING));
    > +
    > + spin_lock(&inode_lock);
    > + list_del_init(&inode->i_wb_list);
    > + __remove_inode_hash(inode);
    > + __inode_sb_list_del(inode);
    > + spin_unlock(&inode_lock);
    > +
    > + evict(inode);
    > +
    > + wake_up_inode(inode);
    > + BUG_ON(inode->i_state != (I_FREEING | I_CLEAR));
    > + destroy_inode(inode);
    > +}

    As this is the only caller of evict left I think the code should just
    be added to evict instead of a new function. Also the hash removal
    should happen after evict, so that __wait_on_freeing_inode still works.



    \
     
     \ /
      Last update: 2010-10-27 09:57    [W:0.020 / U:179.768 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site