Messages in this thread | | | Date | Wed, 27 Oct 2010 12:21:43 -0700 (PDT) | Subject | Re: [PATCH] pktgen: Remove a dangerous debug print. | From | David Miller <> |
| |
From: Nelson Elhage <nelhage@ksplice.com> Date: Wed, 27 Oct 2010 15:13:08 -0400
> We were allocating an arbitrarily-large buffer on the stack, which would allow a > buggy or malicious userspace program to overflow the kernel stack. > > Since the debug printk() was just printing exactly the text passed from > userspace, it's probably just as easy for anyone who might use it to augment (or > just strace(1)) the program writing to the pktgen file, so let's just not bother > trying to print the whole buffer. > > Signed-off-by: Nelson Elhage <nelhage@ksplice.com>
Only root can write to the pktgen control file.
Also, the debug feature really is used by people's pktgen scripts, you can't just turn it off.
| |