Messages in this thread | | | Date | Wed, 27 Oct 2010 13:52:34 -0400 | Subject | Re: [GIT PULL for 2.6.37-rc1] V4L/DVB updates | From | Devin Heitmueller <> |
| |
On Wed, Oct 27, 2010 at 12:46 PM, Mauro Carvalho Chehab <mchehab@redhat.com> wrote: > The original code is broken, as it doesn't properly honour a max size of 8. > Even if we do some optimization at cx231xx, we still need to fix the tda18271 > code, as it is trying to use more than 8 bytes on some writes. > > Also, as you noticed, the way cx231xx sends large firmwares to xc5000 is a hack: > it requires to identify that the I2C device is a xc5000 and do an special > treatment for it.
Yes, it does currently only get run if it's an xc5000, but I believe that code path could be used for *all* devices. There is no reason that it needs to be a hack as that behavior should be the default case (presumably Conexant just didn't want to retest against other devices).
Devin
-- Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com
| |