lkml.org 
[lkml]   [2010]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 24/30] staging/vme_user: remove unnecessary call to vme_slave_set
On Wed, Oct 27, 2010 at 13:24:55 +0100, Martyn Welch wrote:
> On 26/10/10 02:11, Emilio G. Cota wrote:
> > From: Emilio G. Cota <cota@braap.org>
> >
> > The resource is about to be freed and therefore it is pointless to
> > set any of its parameters.
>
> Nope - this is disabling the window, which given that you are about to
> unalloc the memory that it is using this is quite important.

Aah I didn't realise that

> > - vme_slave_set(image[i].resource, 0, 0, 0, 0, VME_A32, 0);

disables the window. I thought vme_slave_free would disable it as well.
Forget this one, then.

Thanks

Emilio



\
 
 \ /
  Last update: 2010-10-27 17:03    [W:0.140 / U:7.212 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site