lkml.org 
[lkml]   [2010]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: nfsd changes for 2.6.37
    Arnd Bergmann wrote:
    > > If you don't hold lock_flocks throughout fcntl_setlease, the flp variable
    > > points to a flock that may get modified by another thread and you call
    > > time_out_leases() without holding lock_flocks, which it requires.

    Whoops, thanks for catching that.

    On Wed, Oct 27, 2010 at 04:39:24AM -0400, Christoph Hellwig wrote:
    > Do locks_alloc_lock and initialization of the heap struct file_lock
    > in the caller. This also avoids an entirely useless copy of the
    > lock structure. free the passed in structure if we are modifying
    > an existing lock structure.

    That sounds good; I'll give it a try.

    --b.


    \
     
     \ /
      Last update: 2010-10-27 15:41    [W:0.061 / U:0.468 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site