Messages in this thread | | | Date | Wed, 27 Oct 2010 09:15:53 -0400 | Subject | Re: [PATCH v3] Topcliff: Update PCH_I2C driver to 2.6.36 | From | Linus Walleij <> |
| |
2010/10/26 Jean Delvare <khali@linux-fr.org>: > On Tue, 26 Oct 2010 18:47:37 +0900, Tomoya MORINAGA wrote: >> Must we get Intel's signature ? >> We have already got the following. Isn't this enough ? >> > Reviewed-by: Linus Walleij <linus.walleij@stericsson.com> >> >> Though I haven't heard like the requirement, >> if Intel's signature is mandatory, I will request to Intel. > > It's not mandatory, but the time Ben and myself have to review new > drivers is scarce, so it's in your own interest to have the code > reviewed by people with more time and more interest in the specific > hardware.
I agree. My Reviewed-by is mainly about the code structure, a few antipatterns were removed and it looks nice to me now. We indeed need someone who knows the hardware to look at this.
Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |