lkml.org 
[lkml]   [2010]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 06/10] drivers/input/serio/i8042: Use pr_<level>, pr_fmt. Fix dbg and __FILE__ use
From
Date
On Tue, 2010-10-26 at 18:28 -0700, Dmitry Torokhov wrote:
> On Oct 26, 2010, at 6:10 PM, Joe Perches <joe@perches.com> wrote:
> > I think 2 defects in 16 uses is a pretty high error rate.
> But how not adding /n is it much better than having it if
> some later change will forget to add it to the message?

Adding \n is the default kernel style.

USB uses a similar dbg macro with a relatively
high error rate.

I fixed some in this commit below awhile ago,
but these keep creeping back in, so they _are_
error prone in actual use.

commit 759f3634267a67ac90f3fa7fc06510dfd43b4e45
Author: Joe Perches <joe@perches.com>
Date: Fri Feb 5 16:50:08 2010 -0800

USB: serial: Remove unnecessary \n's from dbg uses

#define dbg adds the newline, messages shouldn't.
Converted dbg("%s", "some string") to dbg("some string")

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>




\
 
 \ /
  Last update: 2010-10-27 03:39    [W:0.053 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site