Messages in this thread | | | Date | Tue, 26 Oct 2010 17:44:41 -0400 | From | "J. Bruce Fields" <> | Subject | Re: nfsd changes for 2.6.37 |
| |
On Tue, Oct 26, 2010 at 02:37:26PM -0700, Linus Torvalds wrote: > On Tue, Oct 26, 2010 at 2:24 PM, J. Bruce Fields <bfields@fieldses.org> wrote: > > > > I did a couple connectathon runs just now with no obvious ill effects > > except for some sleep-within-spinlock warnings in the lease code. > > Hmm. Those sleep-within-spinlock warnings are very likely serious > bugs.
Yeah, didn't mean to belittle them.
> Can you quote the whole warning with stack trace?
It's just obvious allocations in setlease:
BUG: sleeping function called from invalid context at mm/slab.c:3101 in_atomic(): 1, irqs_disabled(): 0, pid: 4345, name: lease_tests 1 lock held by lease_tests/4345: #0: (file_lock_lock){+.+.+.}, at: [<ffffffff81128be5>] lock_flocks+0x15/0x20 Pid: 4345, comm: lease_tests Not tainted 2.6.36-05858-gbd5e20b #1028 Call Trace: [<ffffffff8103141d>] __might_sleep+0x10d/0x140 [<ffffffff810e3ad3>] kmem_cache_alloc+0x1f3/0x230 [<ffffffff8112a4d2>] generic_setlease+0x112/0x2c0 [<ffffffff8112a6b5>] __vfs_setlease+0x35/0x40 [<ffffffff8112acfe>] fcntl_setlease+0xce/0x180 [<ffffffff810f7c2e>] sys_fcntl+0x2fe/0x630 [<ffffffff81961999>] ? trace_hardirqs_on_thunk+0x3a/0x3f [<ffffffff81002658>] system_call_fastpath+0x16/0x1b
I'm testing a patch.
--b.
| |