Messages in this thread Patch in this message | | | Date | Tue, 26 Oct 2010 15:38:56 +0200 | From | Michal Nazarewicz <> | Subject | [PATCH 5/7] USB: gadget: f_mass_storage: remove needless complete() |
| |
From: Michal Nazarewicz <mina86@mina86.com>
This commit removes call to the complete() function done in fsg_unbind() which was never needed there but was a leftover form file_storage.c.
Signed-off-by: Michal Nazarewicz <mina86@mina86.com> --- drivers/usb/gadget/f_mass_storage.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-)
An additional complete() didn't hurt but at the same time it was rather useless.
diff --git a/drivers/usb/gadget/f_mass_storage.c b/drivers/usb/gadget/f_mass_storage.c index c71f69f..365f1b3 100644 --- a/drivers/usb/gadget/f_mass_storage.c +++ b/drivers/usb/gadget/f_mass_storage.c @@ -2657,7 +2657,7 @@ static int fsg_main_thread(void *common_) up_write(&common->filesem); } - /* Let the unbind and cleanup routines know the thread has exited */ + /* Let fsg_unbind() know the thread has exited */ complete_and_exit(&common->thread_notifier, 0); } @@ -2906,9 +2906,6 @@ static void fsg_common_release(struct kref *ref) if (common->state != FSG_STATE_TERMINATED) { raise_exception(common, FSG_STATE_EXIT); wait_for_completion(&common->thread_notifier); - - /* The cleanup routine waits for this completion also */ - complete(&common->thread_notifier); } if (likely(common->luns)) { -- 1.7.1
| |