Messages in this thread | | | Subject | Re: [PATCH 20/29] memstick: jmb38x_ms: rework PIO | From | Maxim Levitsky <> | Date | Tue, 26 Oct 2010 04:21:40 +0200 |
| |
On Mon, 2010-10-25 at 09:05 -0700, Alex Dubov wrote: > > --- On Fri, 22/10/10, Maxim Levitsky <maximlevitsky@gmail.com> wrote: > > > From: Maxim Levitsky <maximlevitsky@gmail.com> > > Subject: [PATCH 20/29] memstick: jmb38x_ms: rework PIO > > To: "Alex Dubov" <oakad@yahoo.com> > > Cc: "Andrew Morton" <akpm@linux-foundation.org>, "LKML" <linux-kernel@vger.kernel.org>, "Maxim Levitsky" <maximlevitsky@gmail.com> > > Received: Friday, 22 October, 2010, 4:53 PM > > Rewrite PIO code to be just simplier > > and shorter, > > and comment not so obivous parts. > > > > Signed-off-by: Maxim Levitsky<maximlevitsky@gmail.com> > > --- > > Yet, you are fixing something that was not broken before.
A code that is hard to read is broken even if it works, because its very easy for anyone to break it accidentally. Anybody disagree (except you)?
Best regards, Maxim Levitsky
| |