Messages in this thread |  | | | Subject | Re: [PATCH 19/29] memstick: jmb38x_ms: add register read/write functions | | From | Maxim Levitsky <> | | Date | Tue, 26 Oct 2010 04:19:46 +0200 |
| |
On Mon, 2010-10-25 at 09:03 -0700, Alex Dubov wrote: > --- On Fri, 22/10/10, Maxim Levitsky <maximlevitsky@gmail.com> wrote: > > > From: Maxim Levitsky <maximlevitsky@gmail.com> > > Subject: [PATCH 19/29] memstick: jmb38x_ms: add register read/write functions > > To: "Alex Dubov" <oakad@yahoo.com> > > Cc: "Andrew Morton" <akpm@linux-foundation.org>, "LKML" <linux-kernel@vger.kernel.org>, "Maxim Levitsky" <maximlevitsky@gmail.com> > > Received: Friday, 22 October, 2010, 4:53 PM > > All over the code it is a bit easier > > to see the > > register access with this patch. Also set/clear mask > > helpers refactor code a bit, but the biggest reason > > for this patch is to make it possible to trace register > > read/writes with a flip of a module param. > > > > Currently these functions are unused, but will be by later > > code > > > > Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com> > > This looks like a case of: > 1. You've run into a technical difficulty. > 2. You used some temporary code to resolve and document it. > 3. Now this temporary code is forever here to stay. What? What you are accusing me of? This is just an insult.
Having a simple way to trace register writes is always a good thing.
Also I have very similar code in ene_ir and r852. No complains.
Best regards, Maxim Levitsky
|  |