Messages in this thread | | | Subject | Re: [PATCH 10/29] memstick: mspro: create _setup_io helper. | From | Maxim Levitsky <> | Date | Tue, 26 Oct 2010 03:58:47 +0200 |
| |
On Mon, 2010-10-25 at 08:25 -0700, Alex Dubov wrote: > > --- On Fri, 22/10/10, Maxim Levitsky <maximlevitsky@gmail.com> wrote: > > > From: Maxim Levitsky <maximlevitsky@gmail.com> > > Subject: [PATCH 10/29] memstick: mspro: create _setup_io helper. > > To: "Alex Dubov" <oakad@yahoo.com> > > Cc: "Andrew Morton" <akpm@linux-foundation.org>, "LKML" <linux-kernel@vger.kernel.org>, "Maxim Levitsky" <maximlevitsky@gmail.com> > > Received: Friday, 22 October, 2010, 4:53 PM > > This function contains common parts > > of IO setup > > for the state machine, thus reduces the risk > > of using the state machine in wrong way. > > > > 1. This should precede the read_attribute function patch. Why?
> 2. Coding style. checkpatch.pl passed.
-- Best regards, Maxim Levitsky
| |