lkml.org 
[lkml]   [2010]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 08/11] qla4xxx: Remove host_lock unlock() + lock() from qla4xxx_queuecommand()


On Fri, 17 Sep 2010, Nicholas A. Bellinger wrote:

> From: Nicholas Bellinger <nab@linux-iscsi.org>
>
> This patch removes the now legacy host_lock unlock() + lock() optimization
> from ql4_os.c:qla4xxx_queuecommand()
>
> Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
> ---
> drivers/scsi/qla4xxx/ql4_os.c | 8 +-------
> 1 files changed, 1 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
> index 370d40f..cfbe8b5 100644
> --- a/drivers/scsi/qla4xxx/ql4_os.c
> +++ b/drivers/scsi/qla4xxx/ql4_os.c
> @@ -511,26 +511,20 @@ static int qla4xxx_queuecommand(struct scsi_cmnd *cmd,
> test_bit(DPC_RESET_HA_FW_CONTEXT, &ha->dpc_flags))
> goto qc_host_busy;
>
> - spin_unlock_irq(ha->host->host_lock);
> -
> srb = qla4xxx_get_new_srb(ha, ddb_entry, cmd, done);
> if (!srb)
> - goto qc_host_busy_lock;
> + goto qc_host_busy;
>
> rval = qla4xxx_send_command_to_isp(ha, srb);
> if (rval != QLA_SUCCESS)
> goto qc_host_busy_free_sp;
>
> - spin_lock_irq(ha->host->host_lock);
> return 0;
>
> qc_host_busy_free_sp:
> qla4xxx_srb_free_dma(ha, srb);
> mempool_free(srb, ha->srb_mempool);
>
> -qc_host_busy_lock:
> - spin_lock_irq(ha->host->host_lock);
> -
> qc_host_busy:
> return SCSI_MLQUEUE_HOST_BUSY;
>

Let us know if you want us to send it to James
as part of our patch posting. Thanks.

Acked-by: Ravi Anand <ravi.anand@qlogic.com>
> --
> 1.7.2.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>


\
 
 \ /
  Last update: 2010-10-26 03:59    [W:0.040 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site