lkml.org 
[lkml]   [2010]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 08/29] memstick: mspro: add comments to few functions
    From
    Date
    On Mon, 2010-10-25 at 08:18 -0700, Alex Dubov wrote:
    > --- On Fri, 22/10/10, Maxim Levitsky <maximlevitsky@gmail.com> wrote:
    >
    > > From: Maxim Levitsky <maximlevitsky@gmail.com>
    > > Subject: [PATCH 08/29] memstick: mspro: add comments to few functions
    > > To: "Alex Dubov" <oakad@yahoo.com>
    > > Cc: "Andrew Morton" <akpm@linux-foundation.org>, "LKML" <linux-kernel@vger.kernel.org>, "Maxim Levitsky" <maximlevitsky@gmail.com>
    > > Received: Friday, 22 October, 2010, 4:53 PM
    > > a comment before function is not only
    > > a good way
    > > to give some information to the reader, but
    > > it serves as a good anchor point for diff so that
    > > it doesn't produce a diff between different
    > > functions (sigh...)
    > >
    >
    > Comments of new functions belong to the patch which introduces these new
    > functions. And those functions (as I already said) belong to the patch
    > which introduces new functionality, using these functions, desirably,
    > one function at a time.
    You did read the patch didn't you?
    I added few comments to _existing_ functions something that code really
    needs.
    I also did explain why did I do that here, didn't I?
    It makes next patch cleaner, as diff doesn't attempt to create a diff
    between different functions.


    --
    Best regards,
    Maxim Levitsky



    \
     
     \ /
      Last update: 2010-10-26 03:57    [W:3.547 / U:0.160 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site