Messages in this thread | | | Subject | Re: [PATCH 08/29] memstick: mspro: add comments to few functions | From | Maxim Levitsky <> | Date | Tue, 26 Oct 2010 03:54:26 +0200 |
| |
On Mon, 2010-10-25 at 08:18 -0700, Alex Dubov wrote: > --- On Fri, 22/10/10, Maxim Levitsky <maximlevitsky@gmail.com> wrote: > > > From: Maxim Levitsky <maximlevitsky@gmail.com> > > Subject: [PATCH 08/29] memstick: mspro: add comments to few functions > > To: "Alex Dubov" <oakad@yahoo.com> > > Cc: "Andrew Morton" <akpm@linux-foundation.org>, "LKML" <linux-kernel@vger.kernel.org>, "Maxim Levitsky" <maximlevitsky@gmail.com> > > Received: Friday, 22 October, 2010, 4:53 PM > > a comment before function is not only > > a good way > > to give some information to the reader, but > > it serves as a good anchor point for diff so that > > it doesn't produce a diff between different > > functions (sigh...) > > > > Comments of new functions belong to the patch which introduces these new > functions. And those functions (as I already said) belong to the patch > which introduces new functionality, using these functions, desirably, > one function at a time. You did read the patch didn't you? I added few comments to _existing_ functions something that code really needs. I also did explain why did I do that here, didn't I? It makes next patch cleaner, as diff doesn't attempt to create a diff between different functions.
-- Best regards, Maxim Levitsky
| |