lkml.org 
[lkml]   [2010]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 01/29] memstick: core: header cleanups
From
Date
On Mon, 2010-10-25 at 07:44 -0700, Alex Dubov wrote:
> --- On Fri, 22/10/10, Maxim Levitsky <maximlevitsky@gmail.com> wrote:
>
> > Received: Friday, 22 October, 2010, 4:53 PM
> > * Replace the __attribute__((packed))
> > with __packed
>
> This introduces unnecessary noise and can be merged into a common clean-up
> patch.
And what value will that add?

>
> > * Add struct mspro_cmdex_argument, argument for
> > MS_TPC_EX_SET_CMD
> > * Increase size of inline buffer in memstick_request to 32
> > because thats the size of registers and someone might need
> > to read them
> > all. That structure is allocated one per memstick host, so
> > its size
> > doesn't matter.
>
> This functional changes are better be joined with the first patch which
> actually requires them (these are just 4 lines).
Not fully against that, but then what value will that add too?
Currently memstick.h host many unused structures for MS IO stuff.
And for god's sake it has MS_TPC_EX_SET_CMD declared,
so I just add the structure for its argument, whats wrong with doing
that here?

>
> >
> > * Add comments about few members of memstick_request
>
> Belongs to the clean-up or a separate commenting patch.
Why?

As long as the patch is crearly readable I don't see a reason to add
more patches.


Best regards,
Maxim Levitsky



\
 
 \ /
  Last update: 2010-10-26 03:13    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site