lkml.org 
[lkml]   [2010]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 2/2] regulator: max8952 - fix max8952_set_voltage
2010/10/26 Mark Brown <broonie@opensource.wolfsonmicro.com>:
> On Mon, Oct 25, 2010 at 10:17:06AM +0800, Axel Lin wrote:
>> In current implementation, vid is declared as u8,
>> then "vid == -1" is always false, and "vid >= 0" is always true.
>> Thus change it to s8.
>>
>> vid is always less than MAX8952_NUM_DVS_MODE in current implementation,
>> thus remove the cheking for "vid < MAX8952_NUM_DVS_MODE".
>
> This bit seems like reasonable paranoia in the face of future code
> changes and we're not really in a sufficiently fast path to worry about
> cycles - are you sure that this is essential?
>
Ok. I will send a v2 thant only change u8 to s8.

Regards,
Axel


\
 
 \ /
  Last update: 2010-10-26 01:57    [W:0.044 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site