Messages in this thread | | | From | Axel Lin <> | Date | Tue, 26 Oct 2010 07:55:25 +0800 | Subject | Re: [PATCH 2/2] regulator: max8952 - fix max8952_set_voltage |
| |
2010/10/26 Mark Brown <broonie@opensource.wolfsonmicro.com>: > On Mon, Oct 25, 2010 at 10:17:06AM +0800, Axel Lin wrote: >> In current implementation, vid is declared as u8, >> then "vid == -1" is always false, and "vid >= 0" is always true. >> Thus change it to s8. >> >> vid is always less than MAX8952_NUM_DVS_MODE in current implementation, >> thus remove the cheking for "vid < MAX8952_NUM_DVS_MODE". > > This bit seems like reasonable paranoia in the face of future code > changes and we're not really in a sufficiently fast path to worry about > cycles - are you sure that this is essential? > Ok. I will send a v2 thant only change u8 to s8.
Regards, Axel
| |