lkml.org 
[lkml]   [2010]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tracing: Cleanup the convoluted softirq tracepoints
On 10/25/2010 03:01 PM, Mathieu Desnoyers wrote:
> * H. Peter Anvin (hpa@zytor.com) wrote:
>> On 10/20/2010 08:27 AM, Jason Baron wrote:
>>>
>>> sure. The idea of the 'jmp 0' was simply to be an lcd for x86, if
>>> there's a better lcd for x86, I'll update it. But note, that since the
>>> 'jmp 0' is patched to a better nop at boot, we wouldn't see much gain.
>>> And in the boot path we are using 'text_poke_early()', so avoiding that
>>> isn't going to improve things much.
>>>
>>
>> It's still a completely unnecessary waste of startup time some
>> potentially significant fraction of the time. Startup time matters,
>> especially as the number of tracepoints grow.
>
> We're still waiting for input for the best single-5-byte-instruction nop that
> will work on all x86 variants. Please note that the GENERIC_NOP5 is actually two
> instructions one next to each other, which is not appropriate here.
>

On 64 bits, use P6_NOP5; it seems to not suck on any platform.

On 32 bits, 3E 8D 74 26 00 (i.e. DS: + GENERIC_NOP4) seems to at least
do okay.

I can't say these are the *best* (in fact, they are guaranteed not the
best on some significant number of chips), but they haven't sucked on
any chips I have been able to measure -- and are way faster than JMP.

-hpa


\
 
 \ /
  Last update: 2010-10-26 00:17    [W:0.596 / U:0.816 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site