lkml.org 
[lkml]   [2010]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv5 2/3] ARM: imx: Add gpio-keys to plat-mxc
Hello Lothar,

On Mon, Oct 25, 2010 at 09:02:57AM +0200, Lothar Waßmann wrote:
> Uwe Kleine-König writes:
> > On Sun, Oct 24, 2010 at 10:37:19AM +0200, Lothar Waßmann wrote:
> > > Hi,
> > > > >> How do you suggest I define this pin for Babbage board only? Do I add to iomux-mx51.h
> > > > >> #define MX51_BABBAGE_PAD_EIM_A27__GPIO_2_21 IOMUX_PAD(0x45c, 0x0c8, 1, 0x0,
> > > > >0,MX51_GPIO_PAD_CTRL | PAD_CTL_PUS_100K_UP) ?
> > > > >>
> > > > >> Or do I define the pin in the board file with a 100K_UP? Like how eukrea_mbimxsd-baseboard.c did for
> > > > >MBIMXSD_GPIO_3_31?
> > > > >I'd suggest something local to your machine file. Unfortunately I don't
> > > > >see an easy way to reuse the generic MX51_PAD_EIM_A27__GPIO_2_21 to
> > > > >define your local symbol. So I think something like you wrote above
> > > > >should be fine.
> > > > >
> > > > >Too bad that
> > > > >
> > > > > #define MX51_BABBAGE_PAD_EIM_A27__GPIO_2_21 (MX51_PAD_EIM_A27__GPIO_2_21 | PAD_CTL_PUS_100K_UP)
> > > > >
> > > > >doesn't work.
> > > >
> > > > Yes, I also wish I didn't have to redefine the pin just because of PAD setting change. I am going to send out another patch that basically sets the pad_desc.pad_ctrl=PAD_SETTING in mxc_init_board() function. I think it's a bit cleaner than having to redefine the pin.
> > > >
> > > IMO the 'struct pad_desc' should be replaced with an u64 bitmap that
> > > would allow for the pullup and other definitions that may be board
> > > specific to be simply or'ed to the pad definition.
> > >
> > > I could try to provide a patch if this is agreed on.
> > Hmm, I thought about that, too, when writing my mail and when I added
> > the needed space for a struct pad_desc I stopped when it became >64.
> > Somehow I must have got it wrong. After rechecking now it's ==64, so
> > yes, I'd like it.
> >
> What kernel version should I base it on?
> The master branch of git://git.pengutronix.de/git/imx/linux-2.6.git?
I'd use the the for-rmk branch that rmk just pulled for .37. imx/master
is at v2.6.35-rc4 which feels wrong.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-10-25 09:25    [W:0.749 / U:0.908 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site