Messages in this thread | | | Date | Mon, 25 Oct 2010 09:10:05 -0700 (PDT) | From | Alex Dubov <> | Subject | Re: [PATCH 0/29] My patch queue for memorystick subsystem |
| |
> > > Normally, functional > > patches should precede the cosmetic one, so that the > functionality can be > > discussed first. > > More usually it's the other way around, actually: cleanups > come first. > > Because the cleanups are usually uncontroversial, and > because > substantive changes against cleaner code are easier to > review/understand and because the substantive changes are > then easier > to revert or fix. >
My problem here is that out of 30 patches, 20 appear to be rewrites and clean-ups of things not broken.
That's why I'd rather prefer to see actual functional changes first.
| |