lkml.org 
[lkml]   [2010]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/29] memstick: mspro_block: move declarations to header and refactor things a bit
--- On Fri, 22/10/10, Maxim Levitsky <maximlevitsky@gmail.com> wrote:
> From: Maxim Levitsky <maximlevitsky@gmail.com>
> Subject: [PATCH 05/29] memstick: mspro_block: move declarations to header and refactor things a bit
> To: "Alex Dubov" <oakad@yahoo.com>
> Cc: "Andrew Morton" <akpm@linux-foundation.org>, "LKML" <linux-kernel@vger.kernel.org>, "Maxim Levitsky" <maximlevitsky@gmail.com>
> Received: Friday, 22 October, 2010, 4:53 PM
> This makes it much easier to lookup
> things and reduces size of mspro_block.c

Subjective and irrelevant.
My editor makes it easier to look up things when they are in the same file,
and this declarations are not expected to be used by any other compilation
unit. Belongs to the cosmetic category which should be discussed later.

> Also add debbuging macros so that it becames possible to
> control
> debbuging via module param.
>

Should be done through a common kernel infrastructure, namely DYNAMIC_DEBUG
feature (pr_debug and friends).






\
 
 \ /
  Last update: 2010-10-25 17:09    [from the cache]
©2003-2011 Jasper Spaans