| Date | Mon, 25 Oct 2010 08:01:26 -0700 (PDT) | From | Alex Dubov <> | Subject | Re: [PATCH 04/29] memstick: core: rework state machines |
| |
--- On Fri, 22/10/10, Maxim Levitsky <maximlevitsky@gmail.com> wrote:
> From: Maxim Levitsky <maximlevitsky@gmail.com> > Subject: [PATCH 04/29] memstick: core: rework state machines > To: "Alex Dubov" <oakad@yahoo.com> > Cc: "Andrew Morton" <akpm@linux-foundation.org>, "LKML" <linux-kernel@vger.kernel.org>, "Maxim Levitsky" <maximlevitsky@gmail.com> > Received: Friday, 22 October, 2010, 4:53 PM > Make state machines in memstick core > follow the > new style. >
1. This is an important functional patch. At present, "new style" exists only in your head. You should make an effort to justify it to everybody else by providing a rationale in patch description.
2. You are using an integer state variable (instead of function pointers which were self-describing by virtue of the referred function names). Please, define an enumerated type for this state variable, giving states human-readable, descriptive names. If you need to do state variable arithmetic, you can provide a couple of simple, descriptive macros to do so:
#define NEXT_STATE(s) (s + 1)
or something along the line.
3. Coding style.
|