| Date | Mon, 25 Oct 2010 07:56:10 -0700 (PDT) | From | Alex Dubov <> | Subject | Re: [PATCH 03/29] memstick: core: add new functions |
| |
--- On Fri, 22/10/10, Maxim Levitsky <maximlevitsky@gmail.com> wrote:
> From: Maxim Levitsky <maximlevitsky@gmail.com> > Subject: [PATCH 03/29] memstick: core: add new functions > To: "Alex Dubov" <oakad@yahoo.com> > Cc: "Andrew Morton" <akpm@linux-foundation.org>, "LKML" <linux-kernel@vger.kernel.org>, "Maxim Levitsky" <maximlevitsky@gmail.com> > Received: Friday, 22 October, 2010, 4:53 PM > Add a lot of support code that will > be used later. >
You're adding here a lot of temporarily dead code, which, while being useful, should be better added together with the actual driver functionality.
Besides this, the patch has a lot of unneeded clean-ups which are better be set as a separate patch.
And it doesn't conform to the coding guideline either (4 byte indents, instead of tabs).
|