lkml.org 
[lkml]   [2010]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRE: [PATCH 1/2] block: cciss: fix information leak to userland


    > -----Original Message-----
    > From: Vasiliy Kulikov [mailto:segooon@gmail.com]
    > Sent: Saturday, October 23, 2010 3:25 AM
    > To: kernel-janitors@vger.kernel.org
    > Cc: Miller, Mike (OS Dev); Jens Axboe; Stephen M. Cameron;
    > Andrew Morton; ISS StorageDev; linux-kernel@vger.kernel.org
    > Subject: [PATCH 1/2] block: cciss: fix information leak to userland
    >
    > Structure IOCTL_Command_struct is copied to userland with
    > some padding fields at the end of the struct unitialized.
    > It leads to leaking of stack memory.
    >
    > Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
    > ---
    > drivers/block/cciss.c | 1 +
    > 1 files changed, 1 insertions(+), 0 deletions(-)
    >
    > diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
    > index 762a81a..cd08324 100644
    > --- a/drivers/block/cciss.c
    > +++ b/drivers/block/cciss.c
    > @@ -1142,6 +1142,7 @@ static int
    > cciss_ioctl32_passthru(struct block_device *bdev, fmode_t mode,
    > int err;
    > u32 cp;
    >
    > + memset(&arg64, 0, sizeof(arg64));
    > err = 0;
    > err |=
    > copy_from_user(&arg64.LUN_info, &arg32->LUN_info,
    > --

    Acked-by: Mike Miller <mike.miller@hp.com>

    > 1.7.0.4
    >
    >

    \
     
     \ /
      Last update: 2010-10-25 16:45    [W:0.027 / U:59.116 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site