Messages in this thread | | | Date | Sun, 24 Oct 2010 11:53:31 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [PATCH 04/15] x86, apic: Remove early_init_lapic_mapping |
| |
On Sat, 23 Oct 2010, Yinghai Lu wrote:
> It is almost the same as smp_register_lapic_addr() > > Just need to make smp_read_mpc() call smp_register_lapic_addr when early==1.
> @@ -289,17 +289,13 @@ static int __init smp_read_mpc(struct mpc_table *mpc, unsigned early) > #ifdef CONFIG_X86_32 > generic_mps_oem_check(mpc, oem, str); > #endif > - /* save the local APIC address, it might be non-default */ > + /* Initialize the lapic mapping */ > if (!acpi_lapic) > - mp_lapic_addr = mpc->lapic; > + smp_register_lapic_address(mpc->lapic);
How is this restricted to early == 1 ? It's called unconditionally which is nonsense.
Thanks,
tglx
| |