lkml.org 
[lkml]   [2010]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 28/49] tty: Add a new file /proc/tty/consoles
On Sat, Oct 23, 2010 at 01:26:12PM +0100, Al Viro wrote:
> On Sat, Oct 23, 2010 at 02:00:38PM +0200, Jiri Slaby wrote:
>
> > > Please, don't. Even leaving aside the fact that it's mind-bogglingly
> > > broken (->private_data can be _ANYTHING_, including arbitrary number cast
> > > to pointer), you really shouldn't screw your way through the descriptor
> > > table in the first place.
> > >
> > > Strongly NACKed.
> >
> > Well, our complains are -ETOOLATE -- it's commit f4a3e0bceb57466c
> > upstream. So please fix this up.
>
> FVO "fix" equal to "revert". Belated review:
>
> a) global variable depending on stdin of the last opener? Affecting
> output of read(2)? Really?
>
> b) iterator is broken; list should be locked in ->start(), unlocked
> in ->stop() and *NOT* unlocked/relocked in ->next()
>
> c) ->show() ought to do nothing in case of ->device == NULL, instead
> of skipping those in ->next()/->start()
>
> d) regardless of the merits of the bright idea about asterisk at that
> line in output *and* regardless of (a), the implementation is not only
> atrociously ugly, it's actually very likely to be a roothole. Verifying
> that Cthulhu knows what number happens to be address of a tty_struct by
> blindly dereferencing memory at that address... Ouch.
>
> Please revert that crap.

I'll revert it and send the pull request to Linus.

Sorry about this.

greg k-h


\
 
 \ /
  Last update: 2010-10-23 17:49    [W:0.784 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site