[lkml]   [2010]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] sdio: fix suspend/resume regression
    Hi Maxim,

    On Fri, Oct 22, 2010 at 1:47 AM, Maxim Levitsky <> wrote:
    > On Wed, 2010-10-13 at 09:31 +0200, Ohad Ben-Cohen wrote:
    >> Fix SDIO suspend/resume regression introduced by
    >> 4c2ef25fe0b847d2ae818f74758ddb0be1c27d8e "mmc: fix all hangs related to
    >> mmc/sd card insert/removal during suspend/resume":
    >> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
    >> index c94565d..515ff39 100644
    >> --- a/drivers/mmc/core/core.c
    >> +++ b/drivers/mmc/core/core.c
    >> @@ -1682,6 +1682,19 @@ int mmc_suspend_host(struct mmc_host *host)
    >>       if (host->bus_ops && !host->bus_dead) {
    >>               if (host->bus_ops->suspend)
    >>                       err = host->bus_ops->suspend(host);
    >> +             if (err == -ENOSYS || !host->bus_ops->resume) {
    > This reintroduces the bug I fixed.
    > if the CONFIG_MMC_UNSAFE_RESUME isn't set (and that is default
    > unfortunately), the host->bus_ops->resume will be NULL (see core/mmc.c
    > mmc_ops), and therefore card will be removed, that will trigger a block
    > device removal, sync, and deadlock).

    Have you reproduced this or is it just a general concern ?

    I'm asking this because if CONFIG_MMC_UNSAFE_RESUME isn't set, then
    mmc_pm_notify() will remove the card and detach the bus.

    As a result, host->bus_ops will be unset, and host->bus_dead will be set.

    In this case, mmc_suspend_host() should skip the code you are concerned about.

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2010-10-23 12:11    [W:0.042 / U:10.696 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site