Messages in this thread Patch in this message | | | From | Maxim Levitsky <> | Subject | [PATCH 08/29] memstick: mspro: add comments to few functions | Date | Sat, 23 Oct 2010 01:53:36 +0200 |
| |
a comment before function is not only a good way to give some information to the reader, but it serves as a good anchor point for diff so that it doesn't produce a diff between different functions (sigh...)
Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com> --- drivers/memstick/core/mspro_block.c | 14 ++++++++++++++ 1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/drivers/memstick/core/mspro_block.c b/drivers/memstick/core/mspro_block.c index 13cb83b..a7f263d 100644 --- a/drivers/memstick/core/mspro_block.c +++ b/drivers/memstick/core/mspro_block.c @@ -515,6 +515,10 @@ has_int_reg: /*** Data transfer ***/ +/* + * Start execution of next block request, + * or continue execution of the current one + */ static int mspro_block_issue_req(struct memstick_dev *card, int chunk) { struct mspro_block_data *msb = memstick_get_drvdata(card); @@ -575,6 +579,11 @@ try_again: goto try_again; } +/* + * Completes execution of current block request. + * After execution of this function, the msb->block_req might or might not + * be NULL. If it is, it means we don't have any more requests to process + */ static int mspro_block_complete_req(struct memstick_dev *card, int error) { struct mspro_block_data *msb = memstick_get_drvdata(card); @@ -630,6 +639,10 @@ out: return error; } +/* + * This pauses driver. + * Makes sure that driver won't send any commands to the device + */ static void mspro_block_stop(struct memstick_dev *card) { struct mspro_block_data *msb = memstick_get_drvdata(card); @@ -651,6 +664,7 @@ static void mspro_block_stop(struct memstick_dev *card) } } +/* This undoes effects of mspro_block_stop */ static void mspro_block_start(struct memstick_dev *card) { struct mspro_block_data *msb = memstick_get_drvdata(card); -- 1.7.1
| |