Messages in this thread Patch in this message | | | Date | Sat, 23 Oct 2010 01:08:57 +0200 (CEST) | From | Stefan Richter <> | Subject | [PATCH update] firewire: nosy: char device is not seekable |
| |
Remove unnecessary .llseek handler that came in via an automated mass conversion. .llseek = NULL means no_llseek since commit 776c163b1b93.
The only client that uses this interface is nosy-dump in linux/tools/firewire and it knows not to seek in this char dev.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> --- I left out the addition of return nonseekable_open(...) in nosy_open in this update. This works for nosy, but is it also formally correct?
drivers/firewire/nosy.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/firewire/nosy.c b/drivers/firewire/nosy.c index bf184fb..8528b10 100644 --- a/drivers/firewire/nosy.c +++ b/drivers/firewire/nosy.c @@ -405,7 +405,6 @@ static const struct file_operations nosy_ops = { .poll = nosy_poll, .open = nosy_open, .release = nosy_release, - .llseek = noop_llseek, }; #define PHY_PACKET_SIZE 12 /* 1 payload, 1 inverse, 1 ack = 3 quadlets */ -- Stefan Richter -=====-==-=- =-=- =-=== http://arcgraph.de/sr/
| |