Messages in this thread |  | | | From | Rhyland Klein <> | | Date | Fri, 22 Oct 2010 14:41:55 -0700 | | Subject | RE: [PATCH v2] POWER: Add gpio charger driver |
| |
> -----Original Message----- > From: Lars-Peter Clausen [mailto:lars@metafoo.de] > Sent: Thursday, October 21, 2010 10:48 AM > To: Anton Vorontsov > Cc: Rhyland Klein; broonie@opensource.wolfsonmicro.com; Andrew Chew; > olof@lixom.net; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v2] POWER: Add gpio charger driver > > Anton Vorontsov wrote: > > On Thu, Oct 21, 2010 at 05:55:01PM +0200, Lars-Peter Clausen wrote: > >> This patch adds a simple driver for chargers indicating their online > status > >> through a GPIO pin. > >> > >> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> > > > > Hm. I'm getting older, it seems. Now can anybody remind me why > > pda_power.c doesn't work here? ;-) > > > > This driver looks like a light-weigh version of pda_power, except > > that it can do GPIOs directly (instead of is_*_online() callbacks). > > > > Can we instead improve pda_power? Like this: > > > > if (!pdata->is_ac_online && pdata->ac_monitor_gpio) > > pdata->is_ac_online = pda_ac_monitor_gpio; > > > > Should look quite cool, I think. > > > > (Plus, we might get rid of ac/usb stuff in that driver, and > > pass enum power_supply_type to the callbacks instead). > > > > Hi > > Hm... I guess it can be, but on the other hand most platform bus chargers > type > devices can be, because the pda_power driver is keep pretty generic with > custom init, > status and exit callbacks. > > - Lars
Not sure what the state of this driver is, but I figured I would let you know that I tested The driver on my platform and it does indeed work in place of my driver. So I am happy with this one :)
-rhyland
|  |