lkml.org 
[lkml]   [2010]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[041/103] x86, hpet: Fix bogus error check in hpet_assign_irq()
    2.6.35-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Thomas Gleixner <tglx@linutronix.de>

    commit 021989622810b02aab4b24f91e1f5ada2b654579 upstream.

    create_irq() returns -1 if the interrupt allocation failed, but the
    code checks for irq == 0.

    Use create_irq_nr() instead.

    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Cc: Venkatesh Pallipadi <venki@google.com>
    LKML-Reference: <alpine.LFD.2.00.1009282310360.2416@localhost6.localdomain6>
    Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    arch/x86/kernel/hpet.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/arch/x86/kernel/hpet.c
    +++ b/arch/x86/kernel/hpet.c
    @@ -507,7 +507,7 @@ static int hpet_assign_irq(struct hpet_d
    {
    unsigned int irq;

    - irq = create_irq();
    + irq = create_irq_nr(0, -1);
    if (!irq)
    return -EINVAL;




    \
     
     \ /
      Last update: 2010-10-22 21:19    [W:0.028 / U:0.752 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site