[lkml]   [2010]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[38/66] Phonet: Correct header retrieval after pskb_may_pull
2.6.32-stable review patch.  If anyone has any objections, please let us know.


From: Kumar Sanghvi <>

[ Upstream commit a91e7d471e2e384035b9746ea707ccdcd353f5dd ]

Retrieve the header after doing pskb_may_pull since, pskb_may_pull
could change the buffer structure.

This is based on the comment given by Eric Dumazet on Phonet
Pipe controller patch for a similar problem.

Signed-off-by: Kumar Sanghvi <>
Acked-by: Linus Walleij <>
Acked-by: Eric Dumazet <>
Acked-by: Rémi Denis-Courmont <>
Signed-off-by: David S. Miller <>
Signed-off-by: Greg Kroah-Hartman <>
net/phonet/pep.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

--- a/net/phonet/pep.c
+++ b/net/phonet/pep.c
@@ -224,12 +224,13 @@ static void pipe_grant_credits(struct so
static int pipe_rcv_status(struct sock *sk, struct sk_buff *skb)
struct pep_sock *pn = pep_sk(sk);
- struct pnpipehdr *hdr = pnp_hdr(skb);
+ struct pnpipehdr *hdr;
int wake = 0;

if (!pskb_may_pull(skb, sizeof(*hdr) + 4))
return -EINVAL;

+ hdr = pnp_hdr(skb);
if (hdr->data[0] != PN_PEP_TYPE_COMMON) {
LIMIT_NETDEBUG(KERN_DEBUG"Phonet unknown PEP type: %u\n",

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2010-10-22 20:41    [from the cache]
©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site