lkml.org 
[lkml]   [2010]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] block2mtd: dubious assignment
    From
    Date
    On Fri, 2010-10-22 at 16:34 +0200, Jörn Engel wrote:
    > On Fri, 22 October 2010 12:47:24 +0200, Nicolas Kaiser wrote:
    > >
    > > When block2mtd_erase fails, a duplicated assignment instantly
    > > changes instr->state from MTD_ERASE_FAILED to MTD_ERASE_DONE.
    > >
    > > It looks to me like this might not be intended, or is it?
    >
    > Definitely not. Just proves how well block device errors are tested.
    >
    > > Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
    > Acked-By: Joern Engel <joern@logfs.org>
    >
    > Artem, can I leave this patch to you as well?

    Yes, I'll put it to my l2 tree of course, thanks.

    --
    Best Regards,
    Artem Bityutskiy (Битюцкий Артём)

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-10-22 18:17    [W:0.031 / U:32.904 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site