lkml.org 
[lkml]   [2010]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v3 01/12] misc: add driver for sequencer serial port
    Date
    On Friday 22 October 2010 14:39:33 Cyril Chemparathy wrote:
    > >> +/* Register Access Helpers */
    > >> +static inline u32 ssp_read(struct ti_ssp *ssp, int reg)
    > >> +{
    > >> + return __raw_readl(ssp->regs + reg);
    > >> +}
    > >> +
    > >> +static inline void ssp_write(struct ti_ssp *ssp, int reg, u32 val)
    > >> +{
    > >> + __raw_writel(val, ssp->regs + reg);
    > >> +}
    > >
    > > Why are the __raw functions used here?
    > >
    >
    > These registers are to be accessed native endian at all times, and
    > therefore the le32 conversion done otherwise is inappropriate.

    Won't that break on out-of-order CPUs that need the extra synchronization
    done in readl/writel?

    Arnd


    \
     
     \ /
      Last update: 2010-10-22 14:51    [W:0.022 / U:1.120 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site