Messages in this thread Patch in this message | | | Date | Fri, 22 Oct 2010 09:55:51 GMT | From | tip-bot for Alexander van Heukelum <> | Subject | [tip:x86/debug] x86, asm: Fix ancient-GAS workaround |
| |
Commit-ID: a22dcdb0032c78c6b443f6897d7ac432a3b5a272 Gitweb: http://git.kernel.org/tip/a22dcdb0032c78c6b443f6897d7ac432a3b5a272 Author: Alexander van Heukelum <heukelum@fastmail.fm> AuthorDate: Thu, 21 Oct 2010 23:30:49 +0200 Committer: Ingo Molnar <mingo@elte.hu> CommitDate: Fri, 22 Oct 2010 10:45:02 +0200
x86, asm: Fix ancient-GAS workaround
It turns out to generate something like this:
printk ( ("<3>") "something");
The extra parentheses here break the UML compile.
Change the sed-program to add the parentheses only for numbers.
Reported-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: Alexander van Heukelum <heukelum@fastmail.fm> Acked-by: Jan Beulich <jbeulich@novell.com> LKML-Reference: <1287696649.20421.1401306095@webmail.messagingengine.com> Signed-off-by: Ingo Molnar <mingo@elte.hu> --- Kbuild | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/Kbuild b/Kbuild index 3995939..431f7ca 100644 --- a/Kbuild +++ b/Kbuild @@ -53,7 +53,8 @@ targets += arch/$(SRCARCH)/kernel/asm-offsets.s # Default sed regexp - multiline due to syntax constraints define sed-y "/^->/{s:->#\(.*\):/* \1 */:; \ - s:^->\([^ ]*\) [\$$#]*\([^ ]*\) \(.*\):#define \1 (\2) /* \3 */:; \ + s:^->\([^ ]*\) [\$$#]*\([-0-9]*\) \(.*\):#define \1 (\2) /* \3 */:; \ + s:^->\([^ ]*\) [\$$#]*\([^ ]*\) \(.*\):#define \1 \2 /* \3 */:; \ s:->::; p;}" endef
| |