Messages in this thread | | | Date | Thu, 21 Oct 2010 19:14:25 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] percpu_counter : add percpu_counter_add_fast() |
| |
On Fri, 22 Oct 2010 12:58:45 +1100 Nick Piggin <npiggin@kernel.dk> wrote:
> > But what's really alarming is that the compiler (4.0.2) is cheerily > > ignoring the inline directives and was generating out-of-line versions > > of most of the percpu_counter.h functions into lib/proportions.s. > > That's rather a worry. > > You you have the "ignore inlining"
# CONFIG_OPTIMIZE_INLINING is not set
> and "compile for size" turned on?
CONFIG_CC_OPTIMIZE_FOR_SIZE=y
> They often suck.
Everything sucks. Are they any use?
With
# CONFIG_CC_OPTIMIZE_FOR_SIZE is not set CONFIG_OPTIMIZE_INLINING=y
my kernel/built-in.o text went from 563638 bytes to 659852. That's rather a lot.
I haven't looked at this stuff in years. Has anyone dug into it?
| |