lkml.org 
[lkml]   [2010]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: Finishing off cpumask...
Date
On Thu, 21 Oct 2010 07:51:47 pm Peter Zijlstra wrote:
> On Thu, 2010-10-21 at 17:35 +1030, Rusty Russell wrote:
> > The next two turn off and break
> > old-style cpumask uses when CONFIG_CPUMASK_OFFSTACK is set,
>
> Breaking old style for !CONFIG_CPUMASK_OFFSTAK too would be awesome, but
> I guess that's hard to do?

There are four things we could do.
(1) Get rid of the old cpus_ operators (=> cpumask_*). They're just
confusing, and removing them would be a clarity win.
(2) Get rid of cpu_*_map (=> cpu_*_mask). The maps are just wrappers.
(3) Getting rid of cpumask_t (=> struct cpumask) and NR_CPUS
(=> CONFIG_NR_CPUS). These are totally cosmetic.
(4) Getting rid of cpumask_t/struct cpumask (=> cpumask_var_t) is basically
only useful if an arch is thinking about CPUMASK_OFFSTACK, and most
painful.

So, I've changed the CONFIG option which disables (1) and (2); now anyone
will be able to turn it on if they want to test. That might encourage
the per-arch cleanup...

Thanks,
Rusty.


\
 
 \ /
  Last update: 2010-10-22 02:05    [W:0.036 / U:1.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site