lkml.org 
[lkml]   [2010]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] lib/atomic64_test: do not build on non-atomic64 systems
    Date
    On Thursday, October 21, 2010 18:02:50 Andrew Morton wrote:
    > On Sat, 16 Oct 2010 13:27:15 -0400 Mike Frysinger wrote:
    > > If the arch doesn't provide atomic64 functionality (there are quite a
    > > few), then don't bother trying to build this test.
    >
    > I don't get it. If the arch doesn't implement atomic64 then this file
    > will get zillions of build errors, won't it?

    ... which is why i added the ifdef protection

    > > diff --git a/lib/atomic64_test.c b/lib/atomic64_test.c
    > > index 250ed11..0ac1a66 100644
    > > --- a/lib/atomic64_test.c
    > > +++ b/lib/atomic64_test.c
    > > @@ -12,6 +12,8 @@
    > >
    > > #include <linux/kernel.h>
    > > #include <asm/atomic.h>
    > >
    > > +#ifdef ATOMIC64_INIT
    >
    > hm, that's a bit lazy. It should really use a CONFIG_HAVE_ thing. What
    > a pita.

    ATOMIC64_INIT is required for atomic64 headers to provide, and having a
    Kconfig knob doesnt gain anything else
    -mike
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2010-10-22 00:27    [W:0.028 / U:34.120 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site