lkml.org 
[lkml]   [2010]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] gpio led: properly initialize return value
From
Date
On Mon, 2010-10-18 at 12:53 -0300, Davidlohr Bueso wrote:
> gpio led: properly initialize return value in gpio_led_init()
>
> In the event that none of the configs are set (CONFIG_LEDS_GPIO_PLATFORM, CONFIG_LEDS_GPIO_OF,
> CONFIG_LEDS_GPIO_PLATFORM), we will return bogus when initializing the module.
>

Signed-off-by: Davidlohr Bueso <dave@gnu.org>
Cc: Richard Purdie <rpurdie@rpsys.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

> Signed-off-by: Davidlohr Bueso <dave@gnu.org>
> ---
> drivers/leds/leds-gpio.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c
> index ea57e05..4d9fa38 100644
> --- a/drivers/leds/leds-gpio.c
> +++ b/drivers/leds/leds-gpio.c
> @@ -316,7 +316,7 @@ static struct of_platform_driver of_gpio_leds_driver = {
>
> static int __init gpio_led_init(void)
> {
> - int ret;
> + int ret = 0;
>
> #ifdef CONFIG_LEDS_GPIO_PLATFORM
> ret = platform_driver_register(&gpio_led_driver);




\
 
 \ /
  Last update: 2010-10-21 23:23    [W:0.123 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site