lkml.org 
[lkml]   [2010]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] POWER: Add gpio charger driver
On Thu, Oct 21, 2010 at 05:55:01PM +0200, Lars-Peter Clausen wrote:
> This patch adds a simple driver for chargers indicating their online status
> through a GPIO pin.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>

Hm. I'm getting older, it seems. Now can anybody remind me why
pda_power.c doesn't work here? ;-)

This driver looks like a light-weigh version of pda_power, except
that it can do GPIOs directly (instead of is_*_online() callbacks).

Can we instead improve pda_power? Like this:

if (!pdata->is_ac_online && pdata->ac_monitor_gpio)
pdata->is_ac_online = pda_ac_monitor_gpio;

Should look quite cool, I think.

(Plus, we might get rid of ac/usb stuff in that driver, and
pass enum power_supply_type to the callbacks instead).

--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2


\
 
 \ /
  Last update: 2010-10-21 18:29    [W:0.114 / U:2.596 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site