lkml.org 
[lkml]   [2010]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] POWER: Add gpio charger driver
On Thu, Oct 21, 2010 at 05:55:01PM +0200, Lars-Peter Clausen wrote:

> + irq = gpio_to_irq(pdata->gpio);
> + if (irq > 0) {
> + ret = request_irq(irq, gpio_charger_irq,
> + IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
> + dev_name(&pdev->dev), charger);
> + if (ret)
> + dev_warn(&pdev->dev, "Failed to request irq: %d\n", ret);

It would be good to handle IRQs that can sleep (like those on I2C GPIO
expanders) here - either always use a threaded IRQ handler (probably
won't hurt here) or use one if the IRQ can sleep.


\
 
 \ /
  Last update: 2010-10-21 18:03    [W:0.228 / U:0.144 seconds]
©2003-2014 Jasper Spaans. Advertise on this site