Messages in this thread |  | | | Date | Thu, 21 Oct 2010 13:24:33 +0300 | | From | Felipe Balbi <> | | Subject | Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff |
| |
hi,
On Thu, Oct 21, 2010 at 04:04:27AM -0500, Felipe Contreras wrote: >> wouldn't a user expect USB to be enabled if the board _has_ a USB >> connector ? > >Not if it's not going to be used.
and how would you know before hand if it's going to be used or not ?
>>> 1) Do you think all the OMAP3 boards should add that? >> >> why not ? > >You prefer a patch that adds one line per board rather than a patch >that adds one line in total... That is exactly the opposite of Linus's >complaint regarding big ARM changesets.
The thing is that what you are proposing will not scale when we have too many boards with different transceivers. Then we will end up with things like:
config USB_ARCH_HAS_OHCI boolean # ARM: default y if SA1111 default y if ARCH_OMAP default y if ARCH_LH7A404 default y if ARCH_S3C2410 default y if PXA27x default y if PXA3xx default y if ARCH_EP93XX default y if ARCH_AT91 default y if ARCH_PNX4008 && I2C default y if MFD_TC6393XB default y if ARCH_W90X900 default y if ARCH_DAVINCI_DA8XX # PPC: default y if STB03xxx default y if PPC_MPC52xx # MIPS: default y if MIPS_ALCHEMY default y if MACH_JZ4740 # SH: default y if CPU_SUBTYPE_SH7720 default y if CPU_SUBTYPE_SH7721 default y if CPU_SUBTYPE_SH7763 default y if CPU_SUBTYPE_SH7786 # more: default PCI which to me would be much better that e.g. SA1111 does a select USB_ARCH_HAS_OHCI like it's done for HAVE_CLK -- balbi
|  |