Messages in this thread | | | Date | Thu, 21 Oct 2010 01:24:56 +0400 | Subject | Re: [PATCH 3/6] input: Add support for VIA VT8500 and compatibles in i8042 | From | Alexey Charkov <> |
| |
2010/10/21 Dmitry Torokhov <dmitry.torokhov@gmail.com> > > On Wednesday, October 20, 2010 01:55:35 pm Alexey Charkov wrote: > > VIA and WonderMedia Systems-on-Chip feature a standard i8042-compatible > > keyboard and mouse controller. This adds necessary glue to enable use > > of the standard driver with these systems. > > > > Signed-off-by: Alexey Charkov <alchark@gmail.com> > > --- > > > > Please review and state whether this could be acceptable for a merge > > to mainline in the coming 2.6.37 window. If possible, I would deeply > > appreciate a merge to a relevant git tree for integration prior to > > asking Linus to pull the changes. I could rebase the code if needed, > > currently this is against Linus' master branch. > > > > This patch relies on the basic architecture support for VT8500/WM8505 > > to be in place, as introduced by PATCH 1/6 in this series. > > What tree this code will be coming through through? >
Should be Russel King's ARM tree, probably. The whole series is CC'd to linux-arm-kernel and to the relevant subsystems maintainers, as I was instructed to do at a previous submission attempt.
> > + > > +static inline int i8042_platform_init(void) > > +{ > > + i8042_reset = 1; > > = true; - it's a boolean. >
Got it, thanks.
> > + regbase = ioremap(VT8500_PS2_BASE, SZ_1K); > > Error handling? >
Ok, I've missed this. Will be fixed.
> Thanks. > > -- > Dmitry
Thanks for your review, Dmitry! Are there any other issues with this or is it otherwise good enough to receive your Ack? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |