Messages in this thread |  | | | Subject | Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_<level> | | From | Joe Perches <> | | Date | Wed, 20 Oct 2010 11:02:42 -0700 |
| |
On Wed, 2010-10-20 at 10:48 -0700, Guenter Roeck wrote: > The modified define in kernel.org would only apply if pr_fmt isn't already defined, > so that argument is not really correct. The real difference would be that you could > then remove the individual pr_fmt defines from 211 files, and all users of pr_fmt > without module name (ie those hard to read) would be easier to read/identify.
I think that's not a good idea for now, though I agree with the general concept.
This is in kernel.h now.
#ifndef pr_fmt #define pr_fmt(fmt) fmt #endif
A lot of the pr_<level> calls already include some internal prefix.
Try: $ grep -rP --include=*.[ch] -oh "\bpr_\w+\s*\(\s*\"\w+:" * | \ cut -f2- -d"(" | sort | uniq -c | sort -rn You're suggesting modifying 100+ files to get the same output used now.
I think doing something like this after some more generally accepted agreement is reached on how best to do it would be better.
|  |