lkml.org 
[lkml]   [2010]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/3] staging: batman-adv: remove useless addr_to_string()
From
Sorry for that. Resend new version checked by both compilation and sparse.

On Tue, Oct 19, 2010 at 8:03 PM, Greg KH <greg@kroah.com> wrote:
> On Sat, Oct 16, 2010 at 01:11:10PM +0300, Andy Shevchenko wrote:
>> Since all *printf() methods in the kernel understand '%pM' modifier the
>> conversion to the string is useless beforehand.
>>
>> Additionally this patch decreases batman_if structure by 20 bytes.
>
> And also, it breaks the build:
>        drivers/staging/batman-adv/vis.c: In function ‘vis_data_read_entry’:
>        drivers/staging/batman-adv/vis.c:170:38: error: ‘to’ undeclared (first use in this function)
>        drivers/staging/batman-adv/vis.c:170:38: note: each undeclared identifier is reported only once for each function it appears in
>
> Please always test your patches :(
>
> I've dropped this one.
>
> thanks,
>
> greg k-h
>



--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-10-20 13:31    [W:0.056 / U:0.660 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site