Messages in this thread | | | Date | Wed, 20 Oct 2010 10:37:03 +0200 | From | Tejun Heo <> | Subject | Re: [PATCH v2.6.36-rc7] infiniband: update workqueue usage |
| |
Hello,
On 10/19/2010 07:22 PM, Ralph Campbell wrote: > On Tue, 2010-10-19 at 08:24 -0700, Tejun Heo wrote: > >> * qib_cq_wq is a separate singlethread workqueue. Does the queue >> require strict single thread execution ordering? IOW, does each >> work have to be executed in the exact queued order and no two works >> should execute in parallel? Or was the singlethreadedness chosen >> just to reduce the number of workers? > > The work functions need to be called in-order and single threaded > or memory will be freed multiple times and other "bad things".
I see, so they'll need to be converted to alloc_ordered_workqueue() once -rc1 merge window opens up. I'll follow up with the conversion.
Thanks.
-- tejun
| |