lkml.org 
[lkml]   [2010]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2.6.36-rc7] infiniband: update workqueue usage
Hello,

On 10/19/2010 07:22 PM, Ralph Campbell wrote:
> On Tue, 2010-10-19 at 08:24 -0700, Tejun Heo wrote:
>
>> * qib_cq_wq is a separate singlethread workqueue. Does the queue
>> require strict single thread execution ordering? IOW, does each
>> work have to be executed in the exact queued order and no two works
>> should execute in parallel? Or was the singlethreadedness chosen
>> just to reduce the number of workers?
>
> The work functions need to be called in-order and single threaded
> or memory will be freed multiple times and other "bad things".

I see, so they'll need to be converted to alloc_ordered_workqueue()
once -rc1 merge window opens up. I'll follow up with the conversion.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2010-10-20 10:39    [W:0.068 / U:0.956 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site